Skip to content

Improve .dockerignore #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Improve .dockerignore #111

merged 2 commits into from
Mar 8, 2019

Conversation

PhilsLab
Copy link

@PhilsLab PhilsLab commented Mar 7, 2019

Adds some unwanted files for building the project with docker.

Copy link
Contributor

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kylecarbs kylecarbs requested review from nhooyr and removed request for kylecarbs and code-asher March 8, 2019 16:45
@kylecarbs kylecarbs merged commit e418ecf into coder:master Mar 8, 2019
andreimc added a commit to devonlineco/code-server that referenced this pull request Mar 11, 2019
* upstream/master: (35 commits)
  Dockerfile: use relative path instead of $PWD for CMD
  Update docker oneliner and fix clone task
  Clone exact vscode release branch when build task (coder#167)
  Add -t flag to docker example (coder#181)
  Reverts parts of my last PR (coder#177)
  Fix build and Dockerfile issues (coder#176)
  Add nginx reverse proxy guide for selfhosted
  Use a timing-safe equality check for passwords (coder#133)
  Open websocket on same path as page (coder#149)
  Adhere to XDG base directory spec for dataDir and logDir (coder#156)
  Improve github issue template (coder#162)
  Fix typo: environemnt -> environment (coder#159)
  Add back web class
  Move upx compression behind an env flag
  ci: enable travis npm cache (coder#110)
  Improve .dockerignore (coder#111)
  Feature/1.32.0 update (coder#117)
  Update grammar on README (coder#139)
  inital -> initial (coder#135)
  Handle arch in dockerfile and add PR template (coder#109)
  ...
code-asher pushed a commit that referenced this pull request Jun 19, 2019
* impove .dockerignore

* impove .dockerignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants